<div class="gmail_quote">On Tue, May 25, 2010 at 1:27 PM, detlev <span dir="ltr"><<a href="mailto:detlev@die-offenbachs.de">detlev@die-offenbachs.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div class="h5"><br>
</div></div>Thanks for the patch. The code was back-ported from eric5 and I missed this<br>
place (it's the fact that QString is gone in PyQt4 API v2)<br>
<div><div></div><div class="h5"><br></div></div></blockquote></div>That is most probably a nit picking and a matter of taste but the name 'dir' for a<br>local variable is a little bit confusing. In fact because I'm completely unfamiliar <br>
with the PyQt4 API I've bluntly inserted 'print dir(self.dirHistory)' after <br>'if self.dirButton.isChecked():' to see what attributes are available and immediately<br>got an error "using local variable 'dir' before assignment". The better name would <br>
be something like "currentDir". IMHO of course.<br><br>Thanks for the quick fix!<br><br>Regards,<br>-- <br>Mikhail Terekhov<br>