[Eric] Re: version control problems

[Detlev Offenbach]

On Freitag, 6. April 2007, Vicent Mas wrote:
> El Friday, 30 de March de 2007 10:59 Detlev Offenbach escribió:
> > On Montag, 26. März 2007, Vicent Mas wrote:
> > > Hi,
> > >
> > > I'd like to use the version control capabilities of eric4, mainly
> > > diff and commit operations. However they have an unexpected (at
> > > least for me) behavior. First I open the difference window, then I
> > > open the commit one but, once the commit window becomes active, the
> > > difference window (the rest of eric in fact) cannot be activated
> > > again, the only usable window is the commit one. Normally I write
> > > detailed commit logs so I need to read the diffs when I'm writing.
> > > But the current behavior doesn't allow me to do it.
> > >
> > > Is this the expected behavior?
> > >
> > > My versions:
> > >
> > > Python 2.4.4
> > > Qt 4.2.2
> > > PyQt 4.1.1
> > > sip 4.5.2
> > > QScintilla 2-snapshot-20070304
> > > Eric4 4.0-snapshot-20070325
> > > Bicycle Repair Man CVS-20041120
> >
> > The next eric4 snapshot will contain a non-modal commit message
> > dialog. Please give it a try and report back.
> >
> >
> > Detlev
>
> Hi,
>
> I've installed the latest snapshot and tried the commit dialog. There is
> a problem whit svn (I have no tested other version control clients. svn
> is the only one I use). The problem is that changes are not commited to
> the repository after clicking the OK button. Simply nothing happens.
> The attached patch fixes the problem (at least here :-).
>
> Vicent

Oops, I forgot to remove some test code.

Detlev
-- 
Detlev Offenbach
detlev at die-offenbachs.de