[PyKDE] bug in QextScintilla + patch

Jiri Barton jbar at hosting4u.cz
Tue Apr 27 13:49:00 BST 2004


Helllo,

I just found a bug in QextScintilla::text(int line), qextscintilla.cxx. There 
is a buffer overflow: one should append the zero character to the buffer 
after SCI_GETLINE message. The doc to the scintilla clearly states this but 
the code in the QextScintilla::text(int line)  function does not reflect 
this.

Following is the patch that fixes this. Is there another place I should be 
filing bugs or patches for the QScintilla?

TIA,
  jbar

--- /tmp/qextscintilla.cxx      2004-04-27 13:10:29.000000000 +0200
+++ qt/qextscintilla.cxx        2004-04-27 13:11:07.000000000 +0200
@@ -1494,6 +1494,7 @@

        SendScintilla(SCI_GETLINE,line,buf);

+       buf[buflen] = 0;
        QString qs = convertText(buf);
        delete[] buf;




More information about the PyQt mailing list