[PyKDE] Bug in PyQt/SIP snapshot

[Giovanni Bajo]

Giovanni Bajo <rasky at develer.com> wrote:

> Argh, it didn't work out. I'm trying with snapshot-20051212 and PyQt
> snapshot-20051212, and I get this:
>
> sipqtpart0.obj : error LNK2019: unresolved external symbol
> "__declspec(dllimport) public: virtual class QLayoutIterator __thiscall
> QLayout::iterator(void)"
> (__imp_?iterator at QLayout@@UAE?AVQLayoutIterator@@XZ) referenced in
function
> "protected: virtual class QLayoutIterator __thiscall
> sipQLayout::iterator(void)"
> (?iterator at sipQLayout@@MAE?AVQLayoutIterator@@XZ)


It looks like this is the offending hunk in SIP:


@@ -6366,6 +6452,11 @@ static void newFunction(sipSpec *pt,modu
   if (sflags == 0)
    yyerror("Non-class function specified as abstract");

+  /*
+   * GCC (at least) ignores the abstract specification if it
+   * isn't virtual, so we do as well.
+   */
+  if (isvirt)
   setIsAbstract(od);
  }

Backing out this patch makes PyQt3 compilation succeeds. Even if GCC was
right in that regard (I don't understand exactly the comment), Visual Studio
doesn't support that.
-- 
Giovanni Bajo