[PyKDE] sipdistutils fix relinking

Giovanni Bajo rasky at develer.com
Tue Mar 21 12:42:47 GMT 2006


Phil,

I found a bug in sipdistutils: even if it's not necessary to call 'sip'
because the generated files are up-to-date, it's still necessary to add them
into the list of files to compile/link. The attacched patch fixes the
problem.

Thanks
-- 
Giovanni Bajo
-------------- next part --------------
--- ..\sip-snapshot-20060317\sipdistutils.py	2006-03-18 03:30:24.000000000 +0100
+++ sipdistutils.py	2006-03-21 13:40:39.319875000 +0100
@@ -35,7 +35,7 @@
         import sipconfig
         cfg = sipconfig.Configuration()
         return cfg.sip_bin
-    
+
     def _sip_inc_dir(self):
         import sipconfig
         cfg = sipconfig.Configuration()
@@ -69,9 +69,9 @@
             sipbasename = os.path.basename(sip)
             sbf = os.path.join(self.build_temp, replace_suffix(sipbasename, "sbf"))
             if newer(sip, sbf) or self.force:
-              self._sip_compile(sip_bin, sip, sbf)
-              out = self._get_sip_output_list(sbf)
-              generated_sources.extend(out)
+                self._sip_compile(sip_bin, sip, sbf)
+            out = self._get_sip_output_list(sbf)
+            generated_sources.extend(out)
 
         return generated_sources + other_sources
 


More information about the PyQt mailing list