[PyQt] Bugs galore in QAbstractTableModel???

Steve Borho steve at borho.org
Sun Nov 28 16:09:54 GMT 2010


On Sun, Nov 28, 2010 at 8:18 AM, Wolfgang Rohdewald
<wolfgang at rohdewald.de> wrote:
> On Sonntag 28 November 2010, Steve Borho wrote:
>> I found an updated version of the file here:
>>
>> http://bazaar.launchpad.net/~bzr/ubuntu/maverick/qbzr/bzr-ppa/
>> annotate/head:/lib/tests/modeltest.py
>
> this still needs more updates. Mostly for editable models. Like
>
> -        c = insert.pop()
> +        c = self.insert.pop()
>
> or
>
> -        assert(c['last'] == self.model.data(model.index(start-1, 0, c['parent'])))
> +        assert(c['last'] == self.model.data(self.model.index(start-1, 0, c['parent'])))

Indeed, I found these when I started using the file, and checked in a
fixed version here:

http://bitbucket.org/tortoisehg/thg/src/tip/tortoisehg/hgqt/modeltest.py

> also, the alignment test around line 289 seem to be too strict. Qt.alignLeft|Qt.alignTop
> does actually align at top (try with a row containing a check box), so why should
> it be invalid?

Didn't catch that one.

> I am working on making my models bug free by using modeltest (although they do work
> fine as they are) - when done I will publish my new modeltest.py

Excellent.

-- 
Steve Borho


More information about the PyQt mailing list