[PyQt] qreal check needs to be fixed for Qt 5.2

Dmitry Shachnev mitya57 at ubuntu.com
Tue Feb 4 16:39:52 GMT 2014


On Tue, Feb 4, 2014 at 8:26 PM, Phil Thompson
<phil at riverbankcomputing.com> wrote:
>> Reverting to the sizeof-based check that was in PyQt 5.0 makes it work
>> again with both all and new Qt. Why was it changed?
>
> Because you provided a patch...

Oh... /o\

> http://www.riverbankcomputing.com/pipermail/pyqt/2013-August/033089.html

Actually that Debian patch is quite old and authored by a person I
don't even know. When I forwarded it, qreal was the same in all Qt
versions, so I didn't even think about why the first hunk was needed.
Sorry.

> According to previous Debian reports your patch will break ARM builds with
> Qt v5.1 and earlier.

It will definitely work on archs where sizeof(float) !=
sizeof(double). To be honest, I don't know any archs where it is ==.
So far I am able to build PyQt5 only on i386, amd64 and armhf, and
there the sizeof-based check works.

> Hopefully fixed properly in tonight's snapshot.

Thank you.

--
Dmitry Shachnev


More information about the PyQt mailing list