[PyQt] PyQt4's configure-ng.py

[Phil Thompson]

On 21/10/2014 3:17 am, Davide Pesavento wrote:
> Hi Phil,
> 
> I recently changed the PyQt4 Gentoo ebuild to use configure-ng.py for
> building PyQt v4.11.2. The overall experience with the new configure
> script was quite positive, I like the consistent usage of qmake, and
> the switch allowed me to remove some cruft and ugly hacks from the
> ebuild. So thanks a lot for that!
> 
> In the rest of this email I wanted to suggest a couple of improvements
> and report a possible bug.
> 
> (1) Let's start from the bug. When I pass one or more --enable
> arguments to configure-ng.py, check_dbus doesn't run because
> check_modules is not called. The result is that
> target_config.pydbus_module_dir is always the empty string and the
> dbus-python plugin is never built, even if the QtDBus module is
> enabled. PyQt5 might be affected too.
> 
> (2) A few .pro files don't follow qmake naming convention for the
> subdirs template which says that the .pro file basename must be the
> same as the name of the parent directory. This means that a recursive
> qmake invocation from the project root (PyQt{4,5}.pro) will fail. Both
> PyQt4 and PyQt5 are affected, in particular the non-compliant files
> are: designer/python.pro, pylupdate/pylupdate{4,5}.pro,
> pyrcc/pyrcc{4,5}.pro, qmlscene/python.pro. It would be nice if you
> could rename the files so that they respect qmake conventions.
> 
> (3) Fixing (2) also allows to simplify the configure, because it will
> be enough to run qmake just once on the top-level .pro file.

All the above should be fixed in tonight's PyQt4 and PyQt5 snapshots.

*Please* test.

> (4) To conclude, a question: are out-of-source builds supported with
> configure-ng.py? If not, any plans to support them in the near future?

They are supported - I use them.

Phil