[PyQt] sip-4.19: macro errors in sipgen/gencode.c

Fabio Rossi fabrossi79 at gmail.com
Mon Feb 13 10:37:01 GMT 2017


On Mon, Feb 13, 2017 at 11:32 AM, Phil Thompson
<phil at riverbankcomputing.com> wrote:
> On 12 Feb 2017, at 10:18 pm, Fabio Rossi <fabrossi79 at gmail.com> wrote:
>>
>> I have probably found some errors in the gencode.c. Changesets 1611
>> and 1618 changed the name of generated type structure element inside
>> the _sipWrapperType structure. Should we update accordingly the macros
>> in gencode.c ?
>
> I've applied the patch - thanks. However everything affected was deprecated nearly 8 years ago and shouldn't be used.
>
> Phil

Thanks for applying, just realised the patch was incomplete, a hunk was missing

@@ -2885,7 +2885,7 @@
         if (needs_sipClass)
             prcode(fp,
 "\n"
-"    return (sipClass ? sipClass->type : 0);\n"
+"    return (sipClass ? sipClass->wt_td : 0);\n"
 "}\n"
                 );
         else


More information about the PyQt mailing list