[PyQt] PyQt_qreal_double (Was: Re: PyQt5 5.7.1 Bug: debug build on Windows broken)

[Dmitry Shachnev]

Hi Phil!

On Fri, Jan 20, 2017 at 03:41:49PM +0000, Phil Thompson wrote:
> > I hope Phil can clarify what is correct and what is not.
>
> If you are referring to "float" in the above, it is the Python float not the
> C++ float.

Oh, indeed!

> I assume this sets the QT_COORD_TYPE preprocessor symbol. Is it supported to
> do '-qreal int'?

No — only float and double are supported.

> The values being generated are to *disable* those features and not enable
> them. So your patch does exactly the opposite of what you intended.

I knew that I did not understand something. Thanks for the explanation!

On Fri, Jan 20, 2017 at 04:46:12PM +0000, Phil Thompson wrote:
> The patch has been tried before, caused problems and was reverted. In any
> event this, as written, only affects Qt v5.0 and v5.1.
>
> I have changed configure.py to, additionally, use the size comparison for
> Qt v5.2 and later.

I think you can use size comparison for all Qt versions, but what you did
is also fine. Thank you!

--
Dmitry Shachnev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20170120/028180ea/attachment.sig>