[PyQt] --static configure of sip tries to install sip.pyd not sip.lib

[Kyle Altendorf]

On 2018-07-19 14:11, Phil Thompson wrote:
> On 19 Jul 2018, at 7:35 pm, Kyle Altendorf <sda at fstab.net> wrote:
>> 
>> It looks like the SIP configure.py is getting an extension wrong when 
>> --static is specified.  It writes 'sip.pyd' to 'installed.txt' rather 
>> than 'sip.lib'.  This results in the install setp failing because the 
>> .pyd is not present.
>> 
>> https://ci.appveyor.com/project/KyleAltendorf/pyqt5-tools/build/464/job/9hg5x434a0du76dy#L2358
>> 
>> FileNotFoundError: [Errno 2] No such file or directory: 
>> 'C:\\projects\\pyqt5-tools\\sysroot\\native\\Lib\\site-packages\\PyQt5\\sip.pyd'
>> 
>> Maybe:
>> 
>>        mod_ext = '.pyd' if sys.platform == 'win32' else '.so'
>> 
>> should be:
>> 
>>        if sys.platform == 'win32':
>>            mod_ext = '.lib' if opts.static else '.pyd'
>>        else:
>>            mod_ext = '.so'
>> 
>> I observed this directly in 4.19.12 but at least the symptom was 
>> present in 4.19.11.
>> 
>> Then again, maybe something else entirely is the issue since I really 
>> don't know my way around these builds.
> 
> It's already fixed in the current snapshot.


Sorry, I should have checked that first.  Thanks.  I'll dig into this 
tomorrow but the latest error is:

https://ci.appveyor.com/project/KyleAltendorf/pyqt5-tools/build/471/job/ic2v4r4wpgjs0cgu#L2456

C:\projects\pyqt5-tools\venv\Scripts\python.exe 
C:\projects\pyqt5-tools\src\sip-4.19.13.dev1807141053\mk_distinfo.py "" 
C:\projects\pyqt5-tools\sysroot/lib/python3.6/site-packages\PyQt5_sip-4.19.13.dev1807141053.dist-info 
installed.txt
Traceback (most recent call last):
   File 
"C:\projects\pyqt5-tools\src\sip-4.19.13.dev1807141053\mk_distinfo.py", 
line 108, in <module>
     fn_f = open(fn, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: 
'C:\\projects\\pyqt5-tools\\sysroot/lib/python3.6/site-packages\\PyQt5\\sip.pyi'

There is a sip.lib there but, as it says, no sip.pyi.  Just in case you 
are familiar with this offhand as well.

Cheers,
-kyle