[PyQt] Missing QtWebEngine resources in v5.11.3 macOS wheel

[Florian Bruhin]

On Wed, Oct 03, 2018 at 10:20:26PM +0100, Phil Thompson wrote:
> On 3 Oct 2018, at 8:27 pm, Florian Bruhin <me at the-compiler.org> wrote:
> > 
> > Hey,
> > 
> > unfortunately I only tested the Linux wheel when being asked to test the
> > new release - it looks like the macOS release is missing QtWebEngine
> > resources, i.e. the wheel doesn't contain
> > PyQt5/Qt/lib/QtWebEngineCore.framework/Resources/ which causes
> > applications using QtWebEngine to not work at all.
> > 
> > Copying the folder from a 5.11.2 wheel seems to work, and the only thing
> > that changed between Qt 5.11.1 and .2 is the version number in
> > Info.plist.
> 
> That will have to be the workaround for the moment.

FWIW it's possible to produce a fixed wheel like this:

Download 5.11.2 and 5.11.3 wheel:

  pip download PyQt5==5.11.2 --no-deps --platform=macosx_10_6_intel
  pip download PyQt5==5.11.3 --no-deps --platform=macosx_10_6_intel

Unpack both:

  unzip -d 5.11.2 PyQt5-5.11.2-5.11.1-cp35.cp36.cp37.cp38-abi3-macosx_10_6_intel.whl
  unzip -d 5.11.3 PyQt5-5.11.3-5.11.2-cp35.cp36.cp37.cp38-abi3-macosx_10_6_intel.whl

Copy resources:

  cp -R 5.11.2/PyQt5/Qt/lib/QtWebEngineCore.framework/Resources 5.11.3/PyQt5/Qt/lib/QtWebEngineCore.framework

Fix up Qt version number (no other changes between Qt 5.11.1 and .2):

  cd 5.11.3
  sed -e 's/5\.11\.1/5\.11\.2/' -i "" PyQt5/Qt/lib/QtWebEngineCore.framework/Resources/Info.plist

Repack wheel:

  zip -r ../PyQt5-5.11.3.post1-5.11.2-cp35.cp36.cp37.cp38-abi3-macosx_10_6_intel.whl .
  cd ..

I've verified that the resources are equal to what Qt 5.11.2 ships. 

I can't say for sure if it's uploadable to PyPI (though I think it
should with a different filename), and whether pip will pick up the
newer one solely based on the filename (or upload date).
I tried uploading it to test.pypi.org, but it's too large.

Maybe you could give uploading it a try, as that should be simpler as
doing a complete new release, and would fix things (while being a
minimally-invasive change)?

FWIW, here's the one I created as per above:
https://qutebrowser.org/tmp/PyQt5-5.11.3.post1-5.11.2-cp35.cp36.cp37.cp38-abi3-macosx_10_6_intel.whl

Florian

-- 
https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc
         I love long mails! | https://email.is-not-s.ms/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20181004/c46f8d99/attachment.sig>