[PyQt] [SIP] Compilation errors after upgrade to version 4.19.14

[Antoine Lambert]

Hi,

I wanted to upgrade sip to its latest upstream version for generating the
Python bindings of the Tulip graph visualization framework. But the newly
generated bindings code fails to compile and the following type of errors
are reported.

[ 80%] Building CXX object
library/tulip-python/bindings/tulip-core/CMakeFiles/tulip-core-python-bindings.dir/sip_tulippart6.cpp.o
/home/antoine/dev/tulip_build/library/tulip-python/bindings/tulip-core/sip_tulippart4.cpp:12799:10:
error: ‘bool siptlp_GraphProperty::setAllNodeStringValue(const string&,
tlp::Graph*)’ marked ‘override’, but does not override
 void siptlp_GraphProperty::treatEvents(const std::vector< ::tlp::Event>&
a0)
          ^~~~~~~~~~~~~~~~~~~~~
/home/antoine/dev/tulip_build/library/tulip-python/bindings/tulip-core/sip_tulippart4.cpp:12800:10:
error: ‘bool siptlp_GraphProperty::setStringValueToGraphNodes(const
string&, tlp::Graph*)’ marked ‘override’, but does not override
 {
          ^
/home/antoine/dev/tulip_build/library/tulip-python/bindings/tulip-core/sip_tulippart4.cpp:12803:10:
error: ‘bool siptlp_GraphProperty::setAllEdgeStringValue(const string&,
tlp::Graph*)’ marked ‘override’, but does not override

          ^
/home/antoine/dev/tulip_build/library/tulip-python/bindings/tulip-core/sip_tulippart4.cpp:12804:10:
error: ‘bool siptlp_GraphProperty::setStringValueToGraphEdges(const
string&, tlp::Graph*)’ marked ‘override’, but does not override
     sipMeth =
sipIsPyMethod(&sipGILState,&sipPyMethods[1],sipPySelf,SIP_NULLPTR,sipName_treatEvents);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/antoine/dev/tulip_build/library/tulip-python/bindings/tulip-core/sip_tulippart4.cpp:12807:20:
error: ‘std::__cxx11::string
siptlp_GraphProperty::getNodeStringValue(tlp::node)’ marked ‘override’, but
does not override
     {
                    ^
/home/antoine/dev/tulip_build/library/tulip-python/bindings/tulip-core/sip_tulippart4.cpp:12808:20:
error: ‘std::__cxx11::string
siptlp_GraphProperty::getEdgeStringValue(tlp::edge)’ marked ‘override’, but
does not override
          ::tlp::GraphProperty::treatEvents(a0);
                    ^~~~~~~~~~~~~~~~~~
/home/antoine/dev/tulip_build/library/tulip-python/bindings/tulip-core/sip_tulippart4.cpp:15527:10:
error: ‘void siptlp_CoordVectorProperty::copy(tlp::CoordVectorProperty*)’
marked ‘override’, but does not override

If you want to reproduce the issue, I have pushed a branch on GitHub:
https://github.com/anlambert/tulip/tree/tulip-python-sip-4.19.14

Best regards
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20190301/31923d9e/attachment.html>