[PyQt] Incorrect file names in sip-4.19 configure script for Windows

[Patrick Stinson]

Hello,

I ran into a few problems with configuring, building, and installing sip-4.19.19 script on windows using python built from source (with PCBuild\build.bat). Here they are along with my workarounds:


SIP

- It expects site-packages\PyQt5 to already exist when passing —sip-module=PyQt5.sip. I worked around this by patching configure.py to create the dir if it doesn’t exist (see attached diff)

- For a python built from source, configure.py expects pythonxx.lib or pythonXX_d.lib to be in PYTHON_ROOT\\libs. I hacked configure.py to use PYTHON_ROOT\\amd64 instead (see attached diff).

- As with sip above, I hacked configure.py to include the '_d' debug suffix for each entry in installed.txt so that `nmake install` would pick up the correct file names (see attached diff).


PYQT5

- The include paths need to include both PYTHON_ROOT\include for Python.h and PYTHON_ROOT\PC for pyconfig.h. I worked around this by manually appending PYTHON_ROOT\PC to include_paths just before the call to generate_module_makefile().

- As describe above with sip, for a python built from source, configure.py expects pythonxx.lib or pythonXX_d.lib to be in PYTHON_ROOT\\libs. I hacked configure.py to use PYTHON_ROOT\\amd64 instead (see attached diff).

- As with sip above, I hacked configure.py to include the '_d' debug suffix for each entry in installed.txt so that `nmake install` would pick up the correct file names  (see attached diff).


Am I making any big mistakes here that would make life easier?

Thanks!
-Patrick


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20200423/ea74255f/attachment-0003.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.sip.py.diff
Type: application/octet-stream
Size: 794 bytes
Desc: not available
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20200423/ea74255f/attachment-0002.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20200423/ea74255f/attachment-0004.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.pyqt.py.diff
Type: application/octet-stream
Size: 834 bytes
Desc: not available
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20200423/ea74255f/attachment-0003.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.riverbankcomputing.com/pipermail/pyqt/attachments/20200423/ea74255f/attachment-0005.htm>