sip 6.8.0+: AttributeError: 'WrappedClass' object has no attribute 'original_typedef'

[Phil Thompson]

On 09/12/2023 14:58, Scott Talbert wrote:
> On Sat, 9 Dec 2023, Scott Talbert wrote:
> 
>> On Sat, 9 Dec 2023, Phil Thompson wrote:
>> 
>>> On 09/12/2023 02:36, Scott Talbert wrote:
>>>> On Fri, 8 Dec 2023, Phil Thompson wrote:
>>>> 
>>>> Next issue:
>>>> 
>>>> [786/940] Compiling sip/cap/sip_richtextwxTextAttrBorders.cpp
>>>> ../../../../sip/cpp/sip_richtextwxRichTextProperties.cpp: In 
>>>> function
>>>> ‘PyObject* meth_wxRichTextProperties_SetProperty(PyObject*, 
>>>> PyObject*,
>>>> PyObject*)’:
>>>> ../../../../sip/cpp/sip_richtextwxRichTextProperties.cpp:738:21:
>>>> error: invalid ‘const_cast’ from type ‘int’ to type ‘wchar_t*’
>>>>   738 |             sipFree(const_cast<wchar_t *>(1));
>>>>       |                     ^~~~~~~~~~~~~~~~~~~~~~~~
>>>> 
>>>> Waf: Leaving directory
>>>> `/home/talbert/wxPython/doxygen/Phoenix.sip680/build/waf/3.12/gtk3'
>>>> Build failed
>>>>  -> task in '_richtext' failed with exit status 1 (run with -v to
>>>> display more information)
>>>> 
>>>> The file is attached.  It looks like with sip 6.7, the inner 
>>>> argument
>>>> was 'value' not '1'.  Let me know if you need further details.
>>> 
>>> Now fixed in the repo.
>>> 
>>> See also...
>>> 
>>> https://www.riverbankcomputing.com/pipermail/pyqt/2023-October/045557.html
>>> 
>>> ...so you could identify all potential issues in one sweep rather 
>>> than finding them one at a time.
>> 
>> Thanks Phil.  Sorry for forgetting about that note.  I've attached a 
>> diff of wxPython's cpp files (sip 6.7.12 vs 6.8.0+) after your latest 
>> fixes. Of the differences, the only things that look concerning to me 
>> are the changes in sip_advcmodule.cpp and sip_richtextcmodule.cpp.
>> 
>> Let me know if you need more details on those.
> 
> Oh, and also the changes in sip_corewxPyCommandEvent.cpp and
> sip_corewxPyEvent.cpp seem significant.

The two versions of those bits of code are actually functionally the 
same, but I've just committed a fix to make them identical.

Thanks,
Phil