[QScintilla] ANN: QScintilla v2.4.1 Released

[Chris Packham]

On Fri, Jan 15, 2010 at 9:01 AM, Chris Packham <judge.packham at gmail.com> wrote:
> On Fri, Jan 15, 2010 at 5:13 AM, Phil Thompson
> <phil at riverbankcomputing.com> wrote:
>> QScintilla v2.4.1 has been released and is available for download at the
>> usual place.
>>
>> This release adds support for QLexerSpice and QLexerVerilog.
>>
>> Also the "auto-completion list with the Gnome window manager" and the "slow
>> drawing of large amounts of text" problems should be fixed.
>>
>> Phil
>
> Hi,
>
> I think there is a problem with the "auto-completion list with the
> Gnome window manager" fix.
>
> If your Qt4 version is less than 0x040500 you will see the following
> compile errors.
>
> SciClasses.cpp: In constructor ‘SciListBox::SciListBox(QWidget*, ListBoxQt*)’:
> SciClasses.cpp:195: error: expected primary-expression before ‘(’ token
> SciClasses.cpp:195: error: expected primary-expression before ‘*’ token
> SciClasses.cpp:195: error: expected primary-expression before ‘*’ token
> SciClasses.cpp:196: error: expected ‘;’ before ‘:’ token
> SciClasses.cpp:212: error: a function-definition is not allowed here
> before ‘{’ token
> SciClasses.cpp:219: error: no matching function for call to
> ‘SciListBox::~SciListBox()’
> SciClasses.h:101: note: candidates are: virtual SciListBox::~SciListBox()
> SciClasses.cpp:220: error: expected ‘;’ before ‘{’ token
> SciClasses.cpp:228: error: a function-definition is not allowed here
> before ‘{’ token
> SciClasses.cpp:231: error: expected ‘}’ at end of input
> make: *** [SciClasses.o] Error 1
>
> I'll attempt to follow up with a patch but I'm not familiar with the
> problem this code is trying to solve.
>

Here is a patch that should fix this. I've attached the patch as well
because I'm using the gmail web interface which tends to eat in-line
patches.

---

--- SciClasses.cpp.orig 2010-01-14 09:53:49.000000000 -0500
+++ SciClasses.cpp      2010-01-15 09:05:10.856566482 -0500
@@ -131,7 +131,7 @@
 #if QT_VERSION >= 0x040500
     setWindowFlags(Qt::ToolTip|Qt::WindowStaysOnTopHint);
     setAttribute(Qt::WA_StaticContents);
-
+#endif
     setFocusProxy(parent);

     setFrameShape(StyledPanel);
@@ -190,32 +190,11 @@
     }
 }

-#else
-
-SciListBox::SciListBox(QWidget *parent, ListBoxQt *lbx_)
-    : QListBox(parent,0,Qt::WType_Popup|Qt::WStyle_Customize|Qt::WStyle_NoBorder|Qt::WStaticContents),
lbx(lbx_)
-{
-    setFocusProxy(parent);
-
-    setFrameShape(StyledPanel);
-    setFrameShadow(Plain);
-
-    connect(this,SIGNAL(doubleClicked(QListBoxItem *)),
-        SLOT(handleSelection()));
-
-    connect(this,SIGNAL(highlighted(QListBoxItem *)),
-        SLOT(ensureCurrentVisible()));
-}
-
-
 int SciListBox::find(const QString &prefix)
 {
     return index(findItem(prefix, Qt::CaseSensitive|Qt::BeginsWith));
 }

-#endif
-
-
 SciListBox::~SciListBox()
 {
     // Ensure that the main widget doesn't get a focus out event when this is
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qscintilla-2.4.1-fix.patch
Type: text/x-patch
Size: 1088 bytes
Desc: not available
URL: <http://www.riverbankcomputing.com/pipermail/qscintilla/attachments/20100115/208f2022/attachment.bin>