[Eric] Bugs in latest eric4 snapshot

[Detlev Offenbach]

On Dienstag, 10. April 2007, Andreas Pakulat wrote:
> On 09.04.07 20:20:54, Detlev Offenbach wrote:
> > On Montag, 9. April 2007, Andreas Pakulat wrote:
> > > The one I posted seems to work fine (I didn't test everything though),
> > > the one I currently have implemented (without the self.dict_items list,
> > > as references to the objects are already kept in the children list -
> > > afaik) doesn't work when I try to open a file (i.e. show its classes).
> > > I'm also not 100% sure I tested this with the posted patch... So I
> > > guess you should first try it out a bit, before adding it permanently.
> >
> > Ok, I'll play with it tomorrow.
>
> Ok, now that running eric4 inside eric3 works right this was easy to
> find: The asserts I put into the code to make sure that internalPointer
> returned a valid object were a bit wrong :) So attached is a diff where
> the Models have
>
> a) the item_dict removed
> b) use internalPointer all the time
> c) have nearly no errors pointed out by the ModelTest
>
> One thing I couldn't fix is the assert on line 415 in modeltest.py, it
> tests that all valid indexes return a valid QVariant for DisplayRole.
> The problem is that the items under a given parent may have different
> number of columnCount(), so I decided to return QVariant("") in that
> case (see line 80 of BrowserModel.py) as a workaround.
>
> Andreas

Hi,

having had a quick look into the patches showed, that there are still 
references to item_dict in ProjectBrowserModel.py. How should these lines be 
changed? Andreas, please note, that there are more models, which need your 
changes (BreakPointModel and WatchPointModel).

Detlev
-- 
Detlev Offenbach
detlev at die-offenbachs.de