[PyKDE] Extra args in KDialogBase.slotOk, slotCancel

[Phil Thompson]

On Friday 14 May 2004 1:14 pm, Hans-Peter Jansen wrote:
> Hi Phil,
>
> On Friday 14 May 2004 08:30, Phil Thompson wrote:
> > The fix will be in tonight's SIP4 snapshot. Rebuild both PyQt and
> > PyKDE.
>
> Does that fix the closing problems of pyKHTMLPart.py, too:
>
> TypeError: queryClose() takes exactly 1 argument (7 given)
>
> When catching that arguments with *args, and printing them, my x86_64
> box spits out:
>
> queryClose args: (<__main__.qt.QString object at 0x2a96223e30>,
> <__main__.qt.QString object at 0x2a96223fb0>, <__main__.qt.QString
> object at 0x2a96239050>, <__main__.qt.QString object at
> 0x2a962390b0>, None, -1787777593)
> queryExit args: (<__main__.qt.QString object at 0x2a96223e30>,
> <__main__.qt.QString object at 0x2a96223fb0>, <__main__.qt.QString
> object at 0x2a96239050>, <__main__.qt.QString object at
> 0x2a962390b0>, None, 9390432)
>
> This happens with:
>
> qt-3.3.1
> kde-3.2.1
> sip-20040510
> PyQt-20040509-sip4
> PyKDE-3.11rc1-sip4
>
> I would highly appreciate a patch to check against..

Yes, it looks like that was the same bug.

> BTW: What happened to sipgen/gencode.c.patch (attached)? I haven't
> checked, if it's needed, but applies cleanly to sip 4 (20040510).

The code is already included - I wouldn't expect it to apply cleanly.

> Also, I found an unspecified patch in SuSEs build (sip.diff). Would
> you take a look into and check if it is really necessary? At least,
> it also apply cleanly and does no user visible harm, but I hate
> unspecified patches..

It's not necessary - the same code already appears a few lines further down.

Phil