[PyKDE] Extra args in KDialogBase.slotOk, slotCancel

Hans-Peter Jansen hpj at urpla.net
Fri May 14 20:36:01 BST 2004


On Friday 14 May 2004 19:35, Phil Thompson wrote:
>
> Yes, it looks like that was the same bug.

Nice. Since you supplied no patch, I will check that tomorrow..

> > BTW: What happened to sipgen/gencode.c.patch (attached)? I
> > haven't checked, if it's needed, but applies cleanly to sip 4
> > (20040510).
>
> The code is already included - I wouldn't expect it to apply
> cleanly.

Well with some fuzz, and resulted in that sequence doubled..

> > Also, I found an unspecified patch in SuSEs build (sip.diff).
> > Would you take a look into and check if it is really necessary?
> > At least, it also apply cleanly and does no user visible harm,
> > but I hate unspecified patches..
>
> It's not necessary - the same code already appears a few lines
> further down.

Well, you're right. Stupid me. Sorry for bothering. Will check such 
stuff myself before troubling next time..

Sorry again.

Pete




More information about the PyQt mailing list