[PyKDE] A few snapshot-20051219 problems

[Gerard Vermeulen]

On Tue, 20 Dec 2005 08:40:51 +0000
Phil Thompson <phil at riverbankcomputing.co.uk> wrote:

> On Tuesday 20 December 2005 7:27 am, Gerard Vermeulen wrote:
> > (1) A typo:
> >
> > --- sip-snapshot-20051219/sipconfig.py.gv       2005-12-20
> > 07:40:52.000000000 +0100 +++ sip-snapshot-20051219/sipconfig.py  2005-12-20
> > 08:04:31.000000000 +0100 @@ -564,7 +564,7 @@
> >              if self.config.qt_version >= 0x040000:
> >                  # This is really just a help for PyQt's configure.py when
> > it is # detecting what Qt modules are available.
> > -                qtmods = self.config.pyqt_modules[:]
> > +                qtmods = self.config.pyqt_modules.split()
> >                  qtmods.extend(self._qt)
> >
> >                  for mod in qtmods:
> > sip.patch lines 1-11/11 (END)
> 
> That's wrong. There is a problem but it's a bit more fundamental.
> 
Yes, the problem is that the patch breaks building PyQt4, but is needed for
add-on packages (PyQwt).

Maybe something like:

if type(self.config.pyqt_modules) == list: # from PyQt4's configure.py
    qtmods = self.config.pyqt_modules[:]
else: # I get a string from pyqtconfig
    qtmods = self.config.pyqt_modules.split()

Gerard