[PyQt] 2 Updates for the modeltest in PyQt4

Wolfgang Rohdewald wolfgang at rohdewald.de
Sun Feb 20 22:52:13 GMT 2011


On Sonntag 20 Februar 2011, Andreas Pakulat wrote:
> I didn't test yet against an actual model, so might have done
> something wrong in porting.

yep.

lists have no add, it is append

I didn't test either but pylint did

Where do you maintain modeltest.py?

I got it from
http://bazaar.launchpad.net/~bzr/ubuntu/maverick/qbzr/bzr-
ppa/annotate/head:/lib/tests/modeltest.py

I made a few bug fixes and I believe I mailed them back to
the author but now that I check again not all of them made
it in, there are still some self. missing in front of model.*

also, checking values for TextAlignmentRole is still  wrong
there: it does not accept ORed values

I also changed some things to make pylint happy
(my local git commit hook does not let me commit unless pylint is 
silent)

my version, now with your patches:
svn cat 
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdegames/kajongg/src/modeltest.py


there also is a modeltest.py from riverbank in 
contrib/pymodeltest
but it has a lot of missing self and does not contain your
patches.

your paths look like you got it from somewere else again:
tests/modeltest/modeltest.py

so I know about three different copies where
I believe mine has less bugs than the others, and you
seem to be patching a forth copy

-- 
Wolfgang


More information about the PyQt mailing list